Re: [PATCH 0/6] quote_path() clean-ups

From: Jeff King <peff@peff.net>
Date: Sep 10, 2020, 12:39 UTC
Message-ID: <20200910123944.GD57925@coredump.intra.peff.net>
In-Reply-To: <20200908205224.4126551-1-gitster@pobox.com>

On Tue, Sep 08, 2020 at 01:52:18PM -0700, Junio C Hamano wrote:

> So, this is an alternative approach to tackle the same issue
> <xmqq4ko8yxp9.fsf@gitster.c.googlers.com> tried to address.  It
> ended up to be more involved than I would have liked, but it was
> primarily because it needed some function signature changes.

This looks like an improvement to me. I left a few minor comments that might be worth addressing, and a few whose resolution is probably "well, we _could_ do that but it's not worth spending more time on this".

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.