git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] pack-write/docs: update regarding pack naming

From
Jeff King <peff@peff.net>
Date
Jul 23, 2020, 18:32 UTC
Message-ID
<20200723183247.GD3975154@coredump.intra.peff.net>
In-Reply-To
<20200722214031.116161-1-johannes@sipsolutions.net>
On Wed, Jul 22, 2020 at 11:40:31PM +0200, Johannes Berg wrote:
Show 11 quoted lines
> The index-pack documentation explicitly states that the pack
> name is derived from the sorted list of object names, but
> since commit 1190a1acf800 ("pack-objects: name pack files
> after trailer hash") that isn't true anymore.
> 
> Be less explicit in the docs as to what the exact output is,
> and just say that it's whatever goes into the pack name.
> 
> Also update a comment on write_idx_file() since it no longer
> modifies the sha1 variable (it's const now anyway), as noted
> by Junio.

Sorry, I should have fixed these way back in 1190a1acf800. Thanks for fixing them. :)

-Peff
Previous: Junio C Hamano
Message 3 of 3 in “pack-write/docs: update regarding pack naming”
  1. pack-write/docs: update regarding pack namingJohannes Berg, Jul 22, 2020
  2. Junio C HamanoJul 22, 2020
  3. Jeff KingJul 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.