From: Jeff King <peff@peff.net>
Date: Thu, 23 Jul 2020 18:32:47 GMT
Subject: Re: [PATCH v3] pack-write/docs: update regarding pack naming
Message-ID: <20200723183247.GD3975154@coredump.intra.peff.net>
In-Reply-To: <20200722214031.116161-1-johannes@sipsolutions.net>

On Wed, Jul 22, 2020 at 11:40:31PM +0200, Johannes Berg wrote:

> The index-pack documentation explicitly states that the pack
> name is derived from the sorted list of object names, but
> since commit 1190a1acf800 ("pack-objects: name pack files
> after trailer hash") that isn't true anymore.
> 
> Be less explicit in the docs as to what the exact output is,
> and just say that it's whatever goes into the pack name.
> 
> Also update a comment on write_idx_file() since it no longer
> modifies the sha1 variable (it's const now anyway), as noted
> by Junio.

Sorry, I should have fixed these way back in 1190a1acf800. Thanks for
fixing them. :)

-Peff