Re: [PATCH 2/4] upload-pack.c: allow banning certain object filter(s)

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 22, 2020, 20:16 UTC
Message-ID: <20200722201634.GB59352@syl.lan>
In-Reply-To: <20200722092129.GK11341@szeder.dev>

On Wed, Jul 22, 2020 at 11:21:29AM +0200, SZEDER Gábor wrote:

Show 11 quoted lines

> On Thu, Jul 02, 2020 at 04:06:32PM -0400, Taylor Blau wrote:
> > +static void die_if_using_banned_filter(struct upload_pack_data *data)
> > +{
> > +	struct list_objects_filter_options *banned = banned_filter(data,
> > +								   &data->filter_options);
> > +	if (!banned)
> > +		return;
> > +
> > +	packet_writer_error(&data->writer, _("filter '%s' not supported\n"),
>
> Should we really translate the content of the ERR packet?

s/ERR packet/dying message after your other piece of advice, but I think so. This is eventually going to make its way to users, so translating it seems to make sense to me.

I guess they would get it in the localization of the server, not the client, but that doesn't sway me away from this, either.

Show 7 quoted lines

> > +			    list_object_filter_config_name(banned->choice));
> > +	die(_("git upload-pack: banned object filter requested"));
> > +}
> > +
> >  static void receive_needs(struct upload_pack_data *data,
> >  			  struct packet_reader *reader)
> >  {

Thanks, Taylor