Re: [PATCH 2/4] upload-pack.c: allow banning certain object filter(s)

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Jul 22, 2020, 09:17 UTC
Message-ID: <20200722091758.GJ11341@szeder.dev>
In-Reply-To: <20200720200739.GB91942@syl.lan>

On Mon, Jul 20, 2020 at 04:07:39PM -0400, Taylor Blau wrote:

> What I'd rather do is something like:
> 
>   - Introduce this patch series with the 'test_must_fail ok=sigpipe',
>     and no error checking.

die_if_using_banned_filter() shows two error messages: a "fancy" one is sent to the client in the ERR packet, including which particular filter is not supported/allowed, and a simple

  die(_("git upload-pack: banned object filter requested"));

If this die() were to show the same fancy error message as in the ERR packet, then it would always make it to 'git clone's stderr in the tests, so the tests could reliably check that 'git upload-pack' died for the expected reason.

Show 17 quoted lines

>   - Modify clone to swallow these errors and eat a packet or two.
> 
>   - Then, drop the 'ok=sigpipe' from t5616 after 'git clone' is a little
>     bit smarter here.
> 
> Maybe more steps than is strictly necessary, but I think it keeps the
> scope of the review on this series reasonable, which is a tradeoff that
> I'm willing to make.
> 
> > Probably git-clone should ignore SIGPIPE during the network transfer
> > portion of the process for the same reasons given in 143588949c (fetch:
> > ignore SIGPIPE during network operation, 2019-03-03).
> >
> > -Peff
> 
> Thanks,
> Taylor