git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat: remove gmtime

From
Jeff King <peff@peff.net>
Date
May 14, 2020, 22:12 UTC
Message-ID
<20200514221202.GB3074610@coredump.intra.peff.net>
In-Reply-To
<20200514191854.55231-1-carenas@gmail.com>
On Thu, May 14, 2020 at 12:18:54PM -0700, Carlo Marcelo Arenas Belón wrote:
Show 7 quoted lines
> ccd469450a (date.c: switch to reentrant {gm,local}time_r, 2019-11-28)
> removes the only gmtime() call we had and moves to gmtime_r() which
> doesn't have the same portability problems.
> 
> Remove the compat gmtime code since it is no longer needed, and confirm
> by successfull running t4212 in FreeBSD 9.3 amd64 (the oldest I could
> get a hold off).

So gmtime_r() behaves differently than gmtime() on those systems in the face of an overflowing time_t? That seems like an odd implementation choice, but OK. If the test isn't failing, I'm just as happy to get rid of this compat cruft.

-Peff
Previous: Carlo Marcelo Arenas Belón
Message 2 of 2 in “compat: remove gmtime”
  1. compat: remove gmtimeCarlo Marcelo Arenas Belón, May 14, 2020
  2. Jeff KingMay 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.