From: Jeff King <peff@peff.net>
Date: Thu, 14 May 2020 22:12:02 GMT
Subject: Re: [PATCH] compat: remove gmtime
Message-ID: <20200514221202.GB3074610@coredump.intra.peff.net>
In-Reply-To: <20200514191854.55231-1-carenas@gmail.com>

On Thu, May 14, 2020 at 12:18:54PM -0700, Carlo Marcelo Arenas Belón wrote:

> ccd469450a (date.c: switch to reentrant {gm,local}time_r, 2019-11-28)
> removes the only gmtime() call we had and moves to gmtime_r() which
> doesn't have the same portability problems.
> 
> Remove the compat gmtime code since it is no longer needed, and confirm
> by successfull running t4212 in FreeBSD 9.3 amd64 (the oldest I could
> get a hold off).

So gmtime_r() behaves differently than gmtime() on those systems in the
face of an overflowing time_t? That seems like an odd implementation
choice, but OK. If the test isn't failing, I'm just as happy to get rid
of this compat cruft.

-Peff