Re: [PATCH 0/4] credential: documentation updates for maint

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: May 7, 2020, 21:23 UTC
Message-ID: <20200507212348.GA19917@Carlos-MBP>
In-Reply-To: <20200507205909.GA38308@coredump.intra.peff.net>

On Thu, May 07, 2020 at 04:59:09PM -0400, Jeff King wrote:

Show 13 quoted lines

> On Wed, May 06, 2020 at 04:28:48PM -0700, Carlo Marcelo Arenas Belón wrote:
> 
> > Subject: [RFC PATCH 5/4] credential: document encoding assumptions for values
> > 
> > Because of the similarity on the names of the keys with what is defined
> > in RFC3986 is easy to assume the same rules would apply here.
> > 
> > Make sure that the format and encoding is well defined to avoid helper
> > developers assuming incorrectly.
> 
> I'm not sure this really clarifies anything, because it just says "no
> assumptions can be made". Which I guess is a statement, but I'm not sure
> what I'd do with it as a helper developer.

not sure what part of the added lines you are referring to but I am happy to provide some examples of what I would expect to clarify below from what I'd seen from some helpers that I'd read the code from recently.

as an example, I would expect the helper developer to start checking for the locale and calling iconv in cases where it is not using utf-8, before sending it to a storage that requires that (ex: osxkeychain), or utf-16 (maybe in windows).

osxkeychain will probably also check for protocol in a case insensitive way to make sure it is not ignoring credentials that are not all lowercase as it does now.

Carlo