git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] credential: document protocol updates

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
May 5, 2020, 01:39 UTC
Message-ID
<20200505013908.4596-5-carenas@gmail.com>
In-Reply-To
<20200505013908.4596-1-carenas@gmail.com>

Document protocol changes after CVE-2020-11008, while at it do some minor improvements for clarity and consitency.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 Documentation/git-credential.txt | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/Documentation/git-credential.txt b/Documentation/git-credential.txt
index 6f0c7ca80f..73a287e634 100644
--- a/Documentation/git-credential.txt
+++ b/Documentation/git-credential.txt
@@ -104,7 +104,7 @@ INPUT/OUTPUT FORMAT
 credential information in its standard input/output. This information
 can correspond either to keys for which `git credential` will obtain
 the login/password information (e.g. host, protocol, path), or to the
-actual credential data to be obtained (login/password).
+actual credential data to be obtained (username/password).
 
 The credential is split into a set of named attributes, with one
 attribute per line. Each attribute is
@@ -123,7 +123,8 @@ Git understands the following attributes:
 
 `host`::
 
-	The remote hostname for a network credential.
+	The remote hostname for a network credential.  This includes
+	the port number if one was specified.
 
 `path`::
 
@@ -134,7 +135,7 @@ Git understands the following attributes:
 `username`::
 
 	The credential's username, if we already have one (e.g., from a
-	URL, from the user, or from a previously run helper).
+	URL, the configuration, the user, or from a previously run helper).
 
 `password`::
 
@@ -146,8 +147,11 @@ Git understands the following attributes:
 	value is parsed as a URL and treated as if its constituent parts
 	were read (e.g., `url=https://example.com` would behave as if
 	`protocol=https` and `host=example.com` had been provided). This
-	can help callers avoid parsing URLs themselves.  Note that any
-	components which are missing from the URL (e.g., there is no
-	username in the example above) will be set to empty; if you want
-	to provide a URL and override some attributes, provide the URL
-	attribute first, followed by any overrides.
+	can help callers avoid parsing URLs themselves.
+
+	Note that specifying a protocol is mandatory and if the URL
+	type doesn't require a hostname (like for cert://) then an
+	empty ("")  hostname will be generated.
+
+	Components which are missing from the URL (e.g., there is no
+	username in the example above) will be left unset.
-- 
2.26.2.686.gfaf46a9ccd
Previous: Carlo Marcelo Arenas BelónNext: Jeff King
Message 12 of 29 in “credential: minor documentation fixes”
  1. credential: minor documentation fixesCarlo Marcelo Arenas Belón, May 3, 2020
  2. Jeff KingMay 3, 2020
  3. Carlo Marcelo Arenas BelónMay 4, 2020
  4. Jeff KingMay 4, 2020
  5. Carlo Marcelo Arenas BelónMay 4, 2020
  6. Jeff KingMay 4, 2020
  7. Carlo Marcelo Arenas BelónMay 4, 2020
  8. Jeff KingMay 4, 2020
  9. 0/4 credential: documentation updates for maintCarlo Marcelo Arenas Belón, May 5, 2020
  10. 1/4 credential: update description for credential_from_url_gentlyCarlo Marcelo Arenas Belón, May 5, 2020
  11. 2/4 credential: correct order of parameters for credential_matchCarlo Marcelo Arenas Belón, May 5, 2020
  12. 4/4 credential: document protocol updatesCarlo Marcelo Arenas Belón, May 5, 2020
  13. Jeff KingMay 6, 2020
  14. 3/4 credential: update gitcredentials documentationCarlo Marcelo Arenas Belón, May 5, 2020
  15. Jeff KingMay 6, 2020
  16. Jeff KingMay 6, 2020
  17. Carlo Marcelo Arenas BelónMay 6, 2020
  18. Jeff KingMay 7, 2020
  19. Carlo Marcelo Arenas BelónMay 7, 2020
  20. Jeff KingMay 7, 2020
  21. Carlo Marcelo Arenas BelónMay 7, 2020
  22. 0/4 credential: documentation updates for maintCarlo Marcelo Arenas Belón, May 6, 2020
  23. 1/4 credential: update description for credential_from_url_gentlyCarlo Marcelo Arenas Belón, May 6, 2020
  24. 2/4 credential: correct order of parameters for credential_matchCarlo Marcelo Arenas Belón, May 6, 2020
  25. 3/4 credential: update gitcredentials documentationCarlo Marcelo Arenas Belón, May 6, 2020
  26. Jeff KingMay 7, 2020
  27. Junio C HamanoMay 7, 2020
  28. 4/4 credential: document protocol updatesCarlo Marcelo Arenas Belón, May 6, 2020
  29. Jeff KingMay 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.