git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/t0000-basic: make sure subtests also use TEST_SHELL_PATH

From
Jeff King <peff@peff.net>
Date
May 7, 2020, 11:39 UTC
Message-ID
<20200507113935.GB3027470@coredump.intra.peff.net>
In-Reply-To
<20200507010746.83418-1-carenas@gmail.com>
On Wed, May 06, 2020 at 06:07:46PM -0700, Carlo Marcelo Arenas Belón wrote:
> 3f824e91c8 (t/Makefile: introduce TEST_SHELL_PATH, 2017-12-08) allows for
> setting a shell for running the tests, but the generated subtests weren't
> updated.

Yeah, this makes sense. The primary benefit of $TEST_SHELL_PATH was to get better support for special testing options (like using bash's trace_fd with "-x"). But based on recent patches I guess you were wanting to test the behavior of an unusual shell. And if we're testing how the test framework runs, certainly using TEST_SHELL_PATH is the most sensible thing.

-Peff
Previous: Carlo Marcelo Arenas Belón
Message 2 of 2 in “t/t0000-basic: make sure subtests also use TEST_SHELL_PATH”
  1. t/t0000-basic: make sure subtests also use TEST_SHELL_PATHCarlo Marcelo Arenas Belón, May 7, 2020
  2. Jeff KingMay 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.