From: Jeff King <peff@peff.net>
Date: Thu, 07 May 2020 11:39:35 GMT
Subject: Re: [PATCH] t/t0000-basic: make sure subtests also use TEST_SHELL_PATH
Message-ID: <20200507113935.GB3027470@coredump.intra.peff.net>
In-Reply-To: <20200507010746.83418-1-carenas@gmail.com>

On Wed, May 06, 2020 at 06:07:46PM -0700, Carlo Marcelo Arenas Belón wrote:

> 3f824e91c8 (t/Makefile: introduce TEST_SHELL_PATH, 2017-12-08) allows for
> setting a shell for running the tests, but the generated subtests weren't
> updated.

Yeah, this makes sense. The primary benefit of $TEST_SHELL_PATH was to
get better support for special testing options (like using bash's
trace_fd with "-x"). But based on recent patches I guess you were
wanting to test the behavior of an unusual shell. And if we're testing
how the test framework runs, certainly using TEST_SHELL_PATH is the most
sensible thing.

-Peff