Re: [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 5, 2020, 00:14 UTC
- Message-ID
- <20200505001455.GA64230@syl.local>
- In-Reply-To
- <xmqqd07jfm2b.fsf@gitster.c.googlers.com>
On Mon, May 04, 2020 at 02:05:16PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Jeff King <peff@peff.net> writes: > > > Commit 9e468334b4 (ref-filter: fallback on alphabetical comparison, > > 2015-10-30) taught ref-filter's sort to fallback to comparing refnames. > > But it did it at the wrong level, overriding the comparison result for a > > single "--sort" key from the user, rather than after all sort keys have > > been exhausted. > > Good find. It does look like that the fallback was broken from the > very first version when it was introduced, as we did have multiple > keys support back in that version already. > > The fix looks good to me.
Me too.
Reviewed-by: Taylor Blau <me@ttaylorr.com>
> Thanks.
Thanks, Taylor