Re: [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys

From: Danh Doan <congdanhqx@gmail.com>
Date: May 3, 2020, 11:44 UTC
Message-ID: <20200503114351.GA28680@danh.dev>
In-Reply-To: <20200503091157.GA170902@coredump.intra.peff.net>

On 2020-05-03 05:11:57-0400, Jeff King <peff@peff.net> wrote:

Show 10 quoted lines

> +test_expect_success 'for-each-ref --ignore-case works on multiple sort keys' '
> +	# name refs numerically to avoid case-insensitive filesystem conflicts
> +	nr=0 &&
> +	for email in a A b B
> +	do
> +		for subject in a A b B
> +		do
> +			GIT_COMMITTER_EMAIL="$email@example.com" \
> +			git tag -m "tag $subject" icase-$(printf %02d $nr) &&
> +			nr=$((nr+1))||

The CodingGuidelines said we want to spell `$nr` instead of `nr` inside arithmetic expansion for dash older than 0.5.4

I'm not sure if we should go with just `$((nr+1))` or it's better to loosen our Guidelines. Since Debian Jessie (oldest supported Debian) ships 0.5.7. I don't know about other systems.

-- 
Danh