git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] better handling of gigantic config files

From
Jeff King <peff@peff.net>
Date
Apr 13, 2020, 17:20 UTC
Message-ID
<20200413172052.GB8183@coredump.intra.peff.net>
In-Reply-To
<20200413004927.GC55122@syl.local>
On Sun, Apr 12, 2020 at 06:49:27PM -0600, Taylor Blau wrote:
Show 7 quoted lines
> Thanks for doing this. I knew that it rang a bell for some reason, but
> it was because of the upload-pack changes to limit the set of allowed
> object filter choices that I'd sent as an RFC somewhere.
> 
> I was using 'parse_config_key()', and I think that you noted somewhere
> that it was odd that it filled an int and not a size_t. So, thanks very
> much for fixing that case.

Yes, your patch was part of why it was on my mind, though really all of this is the culmination of many years of annoyance. :)

You'll have to update your code to use size_t when the two are merged together. I don't think there's anything else in flight that needs similar treatment, though.

-Peff
Previous: Taylor BlauNext: Taylor Blau
Message 15 of 16 in “better handling of gigantic config files”
  1. 0/6 better handling of gigantic config filesJeff King, Apr 10, 2020
  2. 1/6 remote: drop auto-strlen behavior of make_branch() and make_rewrite()Jeff King, Apr 10, 2020
  3. Junio C HamanoApr 10, 2020
  4. 2/6 parse_config_key(): return subsection len as size_tJeff King, Apr 10, 2020
  5. 3/6 config: drop useless length variable in write_pair()Jeff King, Apr 10, 2020
  6. Junio C HamanoApr 10, 2020
  7. 4/6 git_config_parse_key(): return baselen as size_tJeff King, Apr 10, 2020
  8. 5/6 config: use size_t to store parsed variable baselenJeff King, Apr 10, 2020
  9. 6/6 config: reject parsing of files over INT_MAXJeff King, Apr 10, 2020
  10. Junio C HamanoApr 10, 2020
  11. Jeff KingApr 10, 2020
  12. Taylor BlauApr 13, 2020
  13. Junio C HamanoApr 13, 2020
  14. Taylor BlauApr 13, 2020
  15. Jeff KingApr 13, 2020
  16. Taylor BlauApr 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.