From: Jeff King Date: Mon, 13 Apr 2020 17:20:52 GMT Subject: Re: [PATCH 0/6] better handling of gigantic config files Message-ID: <20200413172052.GB8183@coredump.intra.peff.net> In-Reply-To: <20200413004927.GC55122@syl.local> On Sun, Apr 12, 2020 at 06:49:27PM -0600, Taylor Blau wrote: > Thanks for doing this. I knew that it rang a bell for some reason, but > it was because of the upload-pack changes to limit the set of allowed > object filter choices that I'd sent as an RFC somewhere. > > I was using 'parse_config_key()', and I think that you noted somewhere > that it was odd that it filled an int and not a size_t. So, thanks very > much for fixing that case. Yes, your patch was part of why it was on my mind, though really all of this is the culmination of many years of annoyance. :) You'll have to update your code to use size_t when the two are merged together. I don't think there's anything else in flight that needs similar treatment, though. -Peff