Re: [PATCH] commit-graph: fix buggy --expire-time option

From: Jeff King <peff@peff.net>
Date: Apr 1, 2020, 19:57 UTC
Message-ID: <20200401195708.GA3063415@coredump.intra.peff.net>
In-Reply-To: <xmqqo8sb56m2.fsf@gitster.c.googlers.com>

On Wed, Apr 01, 2020 at 12:49:25PM -0700, Junio C Hamano wrote:

Show 16 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > diff --git a/t/t5324-split-commit-graph.sh b/t/t5324-split-commit-graph.sh
> > index 53b2e6b4555..4e4efcaff22 100755
> > --- a/t/t5324-split-commit-graph.sh
> > +++ b/t/t5324-split-commit-graph.sh
> > @@ -210,8 +210,10 @@ test_expect_success 'test merge stragety constants' '
> >  		git config core.commitGraph true &&
> >  		test_line_count = 2 $graphdir/commit-graph-chain &&
> >  		test_commit 15 &&
> > -		git commit-graph write --reachable --split --size-multiple=10 --expire-time=1980-01-01 &&
> > +		touch -m -t 201801010000.00 $graphdir/extra.graph &&
> 
> We have "test-tool chmtime" since 17e48368 (Add test-chmtime: a
> utility to change mtime on files, 2007-02-24) and refrained from
> using "touch -t" anywhere in our tests.  Can we use it here, too?

There are a couple new ones added last year in t5319. Nobody has complained yet, but I wonder if it's a matter of time.

-Peff