Re: [PATCH] commit-graph: fix buggy --expire-time option

From: Taylor Blau <me@ttaylorr.com>
Date: Apr 1, 2020, 18:56 UTC
Message-ID: <20200401185629.GA13599@syl.local>
In-Reply-To: <bbd2b8e4-47f5-a99e-fb14-b6c1ce2ad9a9@gmail.com>

On Wed, Apr 01, 2020 at 02:17:50PM -0400, Derrick Stolee wrote:

Show 18 quoted lines

> On 4/1/2020 2:11 PM, Derrick Stolee via GitGitGadget wrote:
> > Also I noticed that the help text was copied from the --max-commits
> > option. Fix that help text.
> ...
> > diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
> > index 4a70b33fb5f..8000ff0d2ee 100644
> > --- a/builtin/commit-graph.c
> > +++ b/builtin/commit-graph.c
> > @@ -140,7 +140,7 @@ static int graph_write(int argc, const char **argv)
> >  		OPT_INTEGER(0, "size-multiple", &split_opts.size_multiple,
> >  			N_("maximum ratio between two levels of a split commit-graph")),
> >  		OPT_EXPIRY_DATE(0, "expire-time", &split_opts.expire_time,
> > -			N_("maximum number of commits in a non-base split commit-graph")),
> > +			N_("do not expire files newer than a number of seconds before now")),
>
> and of course I messed this up even now.  Should be:
>
> > +			N_("do not expire files newer than a given date-time")),

I wonder if the double-negative can be avoided. Perhaps this should be instead:

  expire files older than the given date-time

or similar.

> -Stolee

Thanks, Taylor