Re: [PATCH 3/3] configure: respect --without-openssl

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Mar 18, 2020, 11:22 UTC
Message-ID: <20200318112213.GB366567@camp.crustytoothpaste.net>
In-Reply-To: <c08bf880c77b7c43256a275e1102308a829d0ee8.1584516715.git.congdanhqx@gmail.com>

On 2020-03-18 at 07:38:02, Đoàn Trần Công Danh wrote:

Show 19 quoted lines

> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
>  configure.ac | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7468eb6bc8..20a11e1f32 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -544,9 +544,15 @@ GIT_STASH_FLAGS($OPENSSLDIR)
>  
>  AC_CHECK_LIB([crypto], [SHA1_Init],
>  [NEEDS_SSL_WITH_CRYPTO=],
> -[AC_CHECK_LIB([ssl], [SHA1_Init],
> - [NEEDS_SSL_WITH_CRYPTO=YesPlease NO_OPENSSL=],
> - [NEEDS_SSL_WITH_CRYPTO=          NO_OPENSSL=YesPlease])])
> +[
> +if "x$NO_OPENSSL" = xYesPlease; then
> +	AC_MSG_ERROR([Disabled OpenSSL is required for SHA1])

I don't see this in the original. Wouldn't we want to fall back to the default in this case, which would be SHA1DC?

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204