git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/10] removing nth_packed_object_sha1()

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 25, 2020, 00:33 UTC
Message-ID
<20200225003302.GK6462@camp.crustytoothpaste.net>
In-Reply-To
<20200224042625.GA1015553@coredump.intra.peff.net>
On 2020-02-24 at 04:26:25, Jeff King wrote:
Show 14 quoted lines
> This series gets rid of nth_packed_object_sha1(), converting its
> remaining callers to nth_packed_object_oid(). The latter provides better
> type-safety in general, and it also allowed me to clean up some tricky
> bits of the pack-verification code (patch 7 below).
> 
> This was inspired by brian's work in:
> 
>  https://lore.kernel.org/git/20200222201749.937983-2-sandals@crustytoothpaste.net/
> 
> but I decide not to base it on that series. It's semantically
> independent, and with the exception of one line, textually independent
> (patch 4 here touches a different parameter in the same call as the
> patch linked above). So I think it's easier to handle them independently
> and just resolve the trivial conflict.

I think this is the right move. The conflicts will be minor, as you said.

The series looked good to me, and as mentioned, I appreciate you using oidread everywhere. It's nice to get rid of more code with "sha1" in it.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Jeff King
Message 14 of 14 in “removing nth_packed_object_sha1()”
  1. 0/10 removing nth_packed_object_sha1()Jeff King, Feb 24, 2020
  2. 01/10 nth_packed_object_oid(): use customary integer returnJeff King, Feb 24, 2020
  3. Jeff KingFeb 24, 2020
  4. 02/10 pack-objects: read delta base oid into object_id structJeff King, Feb 24, 2020
  5. brian m. carlsonFeb 25, 2020
  6. 03/10 pack-objects: convert oe_set_delta_ext() to use object_idJeff King, Feb 24, 2020
  7. 04/10 pack-objects: use object_id struct in pack-reuse codeJeff King, Feb 24, 2020
  8. 05/10 pack-bitmap: use object_id when loading on-disk bitmapsJeff King, Feb 24, 2020
  9. 06/10 pack-check: convert "internal error" die to a BUG()Jeff King, Feb 24, 2020
  10. 07/10 pack-check: push oid lookup into loopJeff King, Feb 24, 2020
  11. 08/10 packed_object_info(): use object_id for returning delta baseJeff King, Feb 24, 2020
  12. 09/10 packed_object_info(): use object_id internally for delta baseJeff King, Feb 24, 2020
  13. 10/10 packfile: drop nth_packed_object_sha1()Jeff King, Feb 24, 2020
  14. brian m. carlsonFeb 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.