From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 25 Feb 2020 00:33:02 GMT
Subject: Re: [PATCH 0/10] removing nth_packed_object_sha1()
Message-ID: <20200225003302.GK6462@camp.crustytoothpaste.net>
In-Reply-To: <20200224042625.GA1015553@coredump.intra.peff.net>

On 2020-02-24 at 04:26:25, Jeff King wrote:
> This series gets rid of nth_packed_object_sha1(), converting its
> remaining callers to nth_packed_object_oid(). The latter provides better
> type-safety in general, and it also allowed me to clean up some tricky
> bits of the pack-verification code (patch 7 below).
> 
> This was inspired by brian's work in:
> 
>  https://lore.kernel.org/git/20200222201749.937983-2-sandals@crustytoothpaste.net/
> 
> but I decide not to base it on that series. It's semantically
> independent, and with the exception of one line, textually independent
> (patch 4 here touches a different parameter in the same call as the
> patch linked above). So I think it's easier to handle them independently
> and just resolve the trivial conflict.

I think this is the right move.  The conflicts will be minor, as you
said.

The series looked good to me, and as mentioned, I appreciate you using
oidread everywhere.  It's nice to get rid of more code with "sha1" in
it.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204