Re: [PATCH v4 1/5] doc: move author and committer information to git-commit(1)
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jan 20, 2020, 19:22 UTC
- Message-ID
- <20200120192204.GD6570@camp.crustytoothpaste.net>
- In-Reply-To
- <20200120175210.GA3989@coredump.intra.peff.net>
On 2020-01-20 at 17:52:10, Jeff King wrote:
Show 25 quoted lines
> On Mon, Jan 20, 2020 at 05:33:39PM +0000, brian m. carlson wrote: > > > diff --git a/Documentation/git-commit-tree.txt b/Documentation/git-commit-tree.txt > > index 4b90b9c12a..adc2e0d4b7 100644 > > --- a/Documentation/git-commit-tree.txt > > +++ b/Documentation/git-commit-tree.txt > > @@ -42,6 +42,10 @@ tend to just write the result to the file that is pointed at by > > `.git/HEAD`, so that we can always see what the last committed > > state was. > > > > +A commit comment is read from stdin. If a changelog > > +entry is not provided via "<" redirection, 'git commit-tree' will just wait > > +for one to be entered and terminated with ^D. > > + > > OPTIONS > > ------- > > <tree>:: > > This text got moved up, which kind of make sense to me, but... > > it stayed here, so now it's duplicated. Should the old one be dropped? > Or is moving the new text a leftover mistake from rebasing (IIRC, in > your original you dropped this whole "here's how commits work" section). > > Other than that, the patch looks good to me.
Thanks for pointing this out. I'll fix it and if nobody else has comments today, send out a v5 later this week, probably tomorrow.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204