Re: [PATCH 0/3] Re-fix rebase -i with SHA-1 collisions
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jan 17, 2020, 22:37 UTC
- Message-ID
- <20200117223734.GA6570@camp.crustytoothpaste.net>
- In-Reply-To
- <nycvar.QRO.7.76.6.2001171050000.46@tvgsbejvaqbjf.bet>
On 2020-01-17 at 09:51:42, Johannes Schindelin wrote:
Show 13 quoted lines
> > This series looks great to me, and thanks for fixing this. > > > > As mentioned in the PR, I'm happy for you to drop the SHA-256 patch into > > this series if you like, or I can carry it in a future series. Either > > way is fine with me. > > Excellent. Given that the re-fix to avoid short commit ID collisions has > little to do with supporting SHA-256, I would like to keep the patch > series separate, then. > > The question whether to move the SHA-256 support patch into your series is > more a question to Junio, i.e. which patch series will be merged down > faster.
I need to do a reroll of part 8, so I'll pick it into a future series (part 9) of test fixes and drop my patch. That way it won't interfere with either series making progress, but it will still be included at the end.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204