git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] grep: support the --pathspec-from-file option

From
Emily Shaffer <emilyshaffer@google.com>
Date
Dec 17, 2019, 00:33 UTC
Message-ID
<20191217003340.GO135450@google.com>
In-Reply-To
<52cf5a3b-09e4-f4d2-a5d0-36b6ddc442f6@syntevo.com>
On Fri, Dec 13, 2019 at 09:13:09PM +0100, Alexandr Miloslavskiy wrote:
Show 13 quoted lines
> On 13.12.2019 19:26, Junio C Hamano wrote:
> 
> > Hmph.  This has nothing to do with "--pathspec-from-file" that was
> > advertised on the title of the patch.  It used to be that
> > 
> > 	git grep -f one -f two
> > 
> > can be used to read patterns from two sources, but that is no
> > longer possible, is it?  Am I missing a larger benefit to accept
> > this regression?
> 
> Ouch, that comes completely unexpected to me. It's good when someone
> experienced watches over :)

Yeah, I'm surprised by it too - and surprised that there wasn't a test to ensure this behavior.

I can put it back as a callback. I'm going to add a second patch to this topic to enforce 'git grep -f one -f two' with a testcase.

As for missed benefits, they all have to do with ugly code vs. pretty code. I don't think it's enough of a reason to lose functionality.

 - Emily
Previous: Alexandr Miloslavskiy
Message 23 of 23 in “grep: provide pathspecs/patterns via file or stdin”
  1. grep: provide pathspecs/patterns via file or stdinEmily Shaffer, Nov 22, 2019
  2. Denton LiuNov 22, 2019
  3. Junio C HamanoNov 22, 2019
  4. Junio C HamanoNov 22, 2019
  5. Denton LiuNov 22, 2019
  6. Emily ShafferNov 22, 2019
  7. Emily ShafferNov 22, 2019
  8. Junio C HamanoNov 23, 2019
  9. Junio C HamanoNov 22, 2019
  10. grep: support the --pathspec-from-file optionEmily Shaffer, Dec 4, 2019
  11. Denton LiuDec 4, 2019
  12. Junio C HamanoDec 4, 2019
  13. Junio C HamanoDec 4, 2019
  14. Emily ShafferDec 13, 2019
  15. Alexandr MiloslavskiyDec 5, 2019
  16. Emily ShafferDec 13, 2019
  17. Johannes SchindelinDec 6, 2019
  18. SZEDER GáborDec 6, 2019
  19. grep: support the --pathspec-from-file optionEmily Shaffer, Dec 13, 2019
  20. Alexandr MiloslavskiyDec 13, 2019
  21. Junio C HamanoDec 13, 2019
  22. Alexandr MiloslavskiyDec 13, 2019
  23. Emily ShafferDec 17, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.