git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: provide pathspecs/patterns via file or stdin

From
Emily Shaffer <emilyshaffer@google.com>
Date
Nov 22, 2019, 22:02 UTC
Message-ID
<20191122220241.GA56020@google.com>
In-Reply-To
<xmqqwobs7i6u.fsf@gitster-ct.c.googlers.com>
On Fri, Nov 22, 2019 at 11:34:17AM +0900, Junio C Hamano wrote:
Show 11 quoted lines
> Denton Liu <liu.denton@gmail.com> writes:
> 
> > The reason I ask is because (correct me if I'm wrong) a lot of other git
> > commands (like add, reset and checkout) don't seem to accept pathspecs
> > via stdin and could suffer the same problem. xargs seems like a more
> > general way of solving the problem of long command lines.
> 
> You contributors who are potentially throwing your own topics into
> the cauldron, please be paying a bit more attention to other topics
> already cooking in the pot.  I think am/pathspec-from-file wants to
> go in the general direction.

Thanks for pointing it out. It is certainly easy to miss the big picture when you spend your time looking at a bug queue instead of a review queue; we who stand in different places see different things more clearly. I appreciate the reminder to look around a little more.

am/pathspec-from-file does solve this issue in the way that we discussed internally, so I'm excited to base a solution for this issue on that branch instead.

In this situation - where it is not a related fixup for a branch in next, but the topic does rely on that branch - should I send a series which is based on 'next'? How do I make the dependency clear to you via emailed patch?

 - Emily
Previous: Denton LiuNext: Emily Shaffer
Message 6 of 23 in “grep: provide pathspecs/patterns via file or stdin”
  1. grep: provide pathspecs/patterns via file or stdinEmily Shaffer, Nov 22, 2019
  2. Denton LiuNov 22, 2019
  3. Junio C HamanoNov 22, 2019
  4. Junio C HamanoNov 22, 2019
  5. Denton LiuNov 22, 2019
  6. Emily ShafferNov 22, 2019
  7. Emily ShafferNov 22, 2019
  8. Junio C HamanoNov 23, 2019
  9. Junio C HamanoNov 22, 2019
  10. grep: support the --pathspec-from-file optionEmily Shaffer, Dec 4, 2019
  11. Denton LiuDec 4, 2019
  12. Junio C HamanoDec 4, 2019
  13. Junio C HamanoDec 4, 2019
  14. Emily ShafferDec 13, 2019
  15. Alexandr MiloslavskiyDec 5, 2019
  16. Emily ShafferDec 13, 2019
  17. Johannes SchindelinDec 6, 2019
  18. SZEDER GáborDec 6, 2019
  19. grep: support the --pathspec-from-file optionEmily Shaffer, Dec 13, 2019
  20. Alexandr MiloslavskiyDec 13, 2019
  21. Junio C HamanoDec 13, 2019
  22. Alexandr MiloslavskiyDec 13, 2019
  23. Emily ShafferDec 17, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.