Re: Parallel fetch and commit graph writing results in locking failure (even on linux)

From: Jeff King <peff@peff.net>
Date: Dec 13, 2019, 19:52 UTC
Message-ID: <20191213195215.GA862734@coredump.intra.peff.net>
In-Reply-To: <bdb9201f-b77f-ab3c-251f-d902c76fa9bc@gmail.com>

On Fri, Dec 13, 2019 at 02:35:47PM -0500, Derrick Stolee wrote:

Show 8 quoted lines

> I don't think so. I think you just found a bug where the
> fetch.writeCommitGraph logic doesn't work with parallel fetch
> jobs (only one can write at a time).
> 
> I believe the fix would be to write the commit-graph after
> all of the jobs have completed, which should mean we need to
> move the call to write_commit_graph_reachable() somewhere else
> inside builtin/fetch.c.

This should be fixed in master by bcb06e204c (Merge branch 'js/fetch-multi-lockfix', 2019-12-01), I think.

-Peff