git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] gitk: rename "commit summary" to "commit reference"

From
Beat Bolli <dev+git@drbeat.li>
Date
Dec 9, 2019, 18:25 UTC
Message-ID
<20191209182534.309884-2-dev+git@drbeat.li>
In-Reply-To
<20191209182534.309884-1-dev+git@drbeat.li>

Now that the commit reference format has a canonical name, let's use this name in gitk's UI and implementation.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
This commit is optional IMO, but I think it makes sense to use the same
words for the same things.
 gitk-git/gitk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index cc89fb25d2..72c7feec9a 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2640,7 +2640,7 @@ proc makewindow {} {
 	{mc "Diff selected -> this" command {diffvssel 1}}
 	{mc "Make patch" command mkpatch}
 	{mc "Create tag" command mktag}
-	{mc "Copy commit summary" command copysummary}
+	{mc "Copy commit reference" command copyreference}
 	{mc "Write commit to file" command writecommit}
 	{mc "Create new branch" command mkbranch}
 	{mc "Cherry-pick this commit" command cherrypick}
@@ -9389,17 +9389,17 @@ proc mktaggo {} {
     mktagcan
 }
 
-proc copysummary {} {
+proc copyreference {} {
     global rowmenuid autosellen
 
     set cmd [list git show -s --pretty=reference]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }
-    set summary [eval exec $cmd $rowmenuid]
+    set reference [eval exec $cmd $rowmenuid]
 
     clipboard clear
-    clipboard append $summary
+    clipboard append $reference
 }
 
 proc writecommit {} {
-- 
2.23.0.13.gecf2037ff6
Previous: Beat BolliNext: Denton Liu
Message 2 of 4 in “gitk: use --pretty=reference to generate the commit summary”
  1. 1/2 gitk: use --pretty=reference to generate the commit summaryBeat Bolli, Dec 9, 2019
  2. 2/2 gitk: rename "commit summary" to "commit reference"Beat Bolli, Dec 9, 2019
  3. Denton LiuDec 9, 2019
  4. Junio C HamanoDec 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.