git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] gitk: use --pretty=reference to generate the commit summary

From
Beat Bolli <dev+git@drbeat.li>
Date
Dec 9, 2019, 18:25 UTC
Message-ID
<20191209182534.309884-1-dev+git@drbeat.li>

Git learned the "reference" pretty format in 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19). Use it also in gitk instead of duplicating the format string. This way, gitk always follows the formatting convention defined by git.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
Junio, this goes on top of dl/pretty-reference, currently in pu.
Thanks!
 gitk-git/gitk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index a14d7a16b2..cc89fb25d2 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -9392,8 +9392,7 @@ proc mktaggo {} {
 proc copysummary {} {
     global rowmenuid autosellen
 
-    set format "%h (\"%s\", %ad)"
-    set cmd [list git show -s --pretty=format:$format --date=short]
+    set cmd [list git show -s --pretty=reference]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }
-- 
2.23.0.13.gecf2037ff6
Next: Beat Bolli
Message 1 of 4 in “gitk: use --pretty=reference to generate the commit summary”
  1. 1/2 gitk: use --pretty=reference to generate the commit summaryBeat Bolli, Dec 9, 2019
  2. 2/2 gitk: rename "commit summary" to "commit reference"Beat Bolli, Dec 9, 2019
  3. Denton LiuDec 9, 2019
  4. Junio C HamanoDec 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.