git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Nov 25, 2019, 12:59 UTC
Message-ID
<20191125125907.28967-1-szeder.dev@gmail.com>

When 'test_commit_bulk' is invoked in an empty test repository, it prints a "fatal: Needed a single revision" error, but still does what it's supposed to do. A test helper function displaying a fatal error and still succeeding is always suspect to be buggy, but luckily that's not the case here: that error comes from a 'git rev-parse --verify HEAD' command invoked in a condition, which doesn't have anything to verify in an empty repository.

Use the '--quiet' option to suppress that error message.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index b299ecc326..6302bfb51d 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -308,7 +308,7 @@ test_commit_bulk () {
 	total=$1
 
 	add_from=
-	if git -C "$indir" rev-parse --verify "$ref"
+	if git -C "$indir" rev-parse --quiet --verify "$ref"
 	then
 		add_from=t
 	fi
-- 
2.24.0.587.g7096fda53a
Next: Jeff King
Message 1 of 2 in “test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'”
  1. test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'SZEDER Gábor, Nov 25, 2019
  2. Jeff KingNov 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.