threads / patch / 52329

patchtest-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

Subject: [PATCH] test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

## tl;dr

2 messages between Nov 25, 2019 and Nov 25, 2019. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

SZEDER Gábor· Nov 25, 2019, 12:59 UTC · lore

When 'test_commit_bulk' is invoked in an empty test repository, it prints a "fatal: Needed a single revision" error, but still does what it's supposed to do. A test helper function displaying a fatal error and still succeeding is always suspect to be buggy, but luckily that's not the case here: that error comes from a 'git rev-parse --verify HEAD' command invoked in a condition, which doesn't have anything to verify in an empty repository.

Use the '--quiet' option to suppress that error message.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/test-lib-functions.sh +1 −1

diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index b299ecc326..6302bfb51d 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -308,7 +308,7 @@ test_commit_bulk () {
 	total=$1
 
 	add_from=
-	if git -C "$indir" rev-parse --verify "$ref"
+	if git -C "$indir" rev-parse --quiet --verify "$ref"
 	then
 		add_from=t
 	fi

-- 
2.24.0.587.g7096fda53a

Jeff King· Nov 25, 2019, 13:19 UTC · re: SZEDER Gábor · lore

Re: [PATCH] test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

On Mon, Nov 25, 2019 at 01:59:07PM +0100, SZEDER Gábor wrote:

Show 9 quoted lines

> When 'test_commit_bulk' is invoked in an empty test repository, it
> prints a "fatal: Needed a single revision" error, but still does what
> it's supposed to do.  A test helper function displaying a fatal error
> and still succeeding is always suspect to be buggy, but luckily that's
> not the case here: that error comes from a 'git rev-parse --verify
> HEAD' command invoked in a condition, which doesn't have anything to
> verify in an empty repository.
> 
> Use the '--quiet' option to suppress that error message.

Yep, makes perfect sense. Thanks.

-Peff