[RFC PATCH v2 1/4] builtin/rebase.c: reuse loop variable
- From
Andrei Rybak <rybak.a.v@gmail.com>
- Date
- Nov 20, 2019, 09:52 UTC
- Message-ID
- <20191120095238.4349-2-rybak.a.v@gmail.com>
- In-Reply-To
- <20191114163549.7648-1-rybak.a.v@gmail.com>
Variable "int i" is already defined at the top of the function cmd_rebase, so reuse it instead of declaring other variables, which mask the outer "i".
Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> --- builtin/rebase.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c index 4a20582e72..793cac1386 100644 --- a/builtin/rebase.c +++ b/builtin/rebase.c @@ -1747,8 +1747,6 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) } if (exec.nr) { - int i; - imply_interactive(&options, "--exec"); strbuf_reset(&buf); @@ -1769,8 +1767,6 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) } if (strategy_options.nr) { - int i; - if (!options.strategy) options.strategy = "recursive";
-- 2.24.0.windows.2