git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH v2 0/4] rebase --edit-todo --exec

From
Andrei Rybak <rybak.a.v@gmail.com>
Date
Nov 20, 2019, 09:52 UTC
Message-ID
<20191120095238.4349-1-rybak.a.v@gmail.com>
In-Reply-To
<20191114163549.7648-1-rybak.a.v@gmail.com>
Differences from v1:
  - Added missing RFC marker.
  - Fixed CC list.
  - Addressed Junio's comment about masked variable in a for loop: another
    preparatory patch is added.
  - Cleaned up copy-pasted unused code in the new test.
----

Original cover letter: I've wanted this feature for a long time, and now with rebase working without forking rebase--interactive (thanks to Phillip Wood for working on that), I finally got around to implementing it.

It still needs validation for arguments. Right now, I have two ideas:
  1. iterate over original argv and make sure its just '--exec's with its
     arguments.
  2. check all other vars in options[].
Andrei Rybak (4):
  builtin/rebase.c: reuse loop variable
  rebase: prepare cmd before choosing action
  rebase: extract add_exec()
  rebase -i: allow --edit-todo with --exec
 Documentation/git-rebase.txt  |  3 +-
 builtin/rebase.c              | 63 +++++++++++++++++++++--------------
 t/t3404-rebase-interactive.sh | 32 ++++++++++++++++++
 3 files changed, 72 insertions(+), 26 deletions(-)
-- 
2.24.0.windows.2
Previous: Andrei RybakNext: Andrei Rybak
Message 11 of 13 in “rebase --edit-todo --exec”
  1. 0/3 rebase --edit-todo --execAndrei Rybak, Nov 14, 2019
  2. 1/3 rebase: prepare cmd before choosing actionAndrei Rybak, Nov 14, 2019
  3. Junio C HamanoNov 15, 2019
  4. 2/3 rebase: extract add_exec()Andrei Rybak, Nov 14, 2019
  5. 3/3 rebase -i: allow --edit-todo with --execAndrei Rybak, Nov 14, 2019
  6. 1/4 builtin/rebase.c: reuse loop variableAndrei Rybak, Nov 20, 2019
  7. Junio C HamanoNov 21, 2019
  8. 2/4 rebase: prepare cmd before choosing actionAndrei Rybak, Nov 20, 2019
  9. Junio C HamanoNov 21, 2019
  10. Andrei RybakNov 22, 2019
  11. 0/4 rebase --edit-todo --execAndrei Rybak, Nov 20, 2019
  12. 3/4 rebase: extract add_exec()Andrei Rybak, Nov 20, 2019
  13. 4/4 rebase -i: allow --edit-todo with --execAndrei Rybak, Nov 20, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.