Re: [PATCH v4 0/2] git-gui: revert untracked files by deleting them

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Nov 19, 2019, 15:21 UTC
Message-ID: <20191119152156.tzsh2hxgcgcegvtt@yadavpratyush.com>
In-Reply-To: <pull.436.v4.git.1573973770.gitgitgadget@gmail.com>

On 17/11/19 06:56AM, Jonathan Gilbert via GitGitGadget wrote:

>  * The initialization code in git-gui.sh (which I'm assuming 
>  translates
>    somehow to git-gui.tcl in the installation?) now explicitly clears the

Well, the design is a bit strange. git-gui.sh happens to be _both_ a shell script and a Tcl script. When you run './git-gui.sh', it is executed as a shell script. That shell script then executes itself via 'wish' (which is the Tcl/Tk windowing shell), and Tcl ignores the first "line" (it is actually the lines 3-10, but they all have an escaped newline so it is effectively a single line).

It has been like since the very first revision of git-gui. I wonder why the original author went with this instead of just doing something like:

  #!/usr/bin/env wish

which seems to work just fine on my quick testing, but that is another topic entirely ;)

>    "Initializing..." status bar text, since the new status bar model won't
>    do this automatically when operations are performed.

PS: I am in the process of reviewing the latest revision of the patch 
series. But I have been short on free time recently so it might take me 
a couple more days.

-- 
Regards,
Pratyush Yadav