Re: [PATCH] fetch: remove fetch_if_missing=0

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Nov 5, 2019, 18:58 UTC

Message-ID

<20191105185845.GA94320@google.com>

In-Reply-To

<20191105185322.205317-1-jonathantanmy@google.com>

Jonathan Tan wrote:

> I think it's less error-prone if we always have a "git" command on its
> own on a line, to avoid losing its error code. When piped into another
> invocation, or when command-substituted into an argument (e.g. "echo
> $(git hash-object foo)"), we lose its error code.

Sure, but assignment is a special case:

	if myvar=$(false)
	then
		echo yes
	else
		echo no
	fi

prints "no".