Re: [PATCH 1/3] t0028: eliminate non-standard usage of printf

From: Danh Doan <congdanhqx@gmail.com>
Date: Nov 1, 2019, 01:33 UTC
Message-ID: <20191101013307.GD30350@danh.dev>
In-Reply-To: <20191031174118.GA2133@sigill.intra.peff.net>

On 2019-10-31 13:41:18 -0400, Jeff King wrote:

Show 8 quoted lines

> So I think your patch is the right thing to do (hex escapes in shell
> printf are definitely not portable), but we might want to note something
> like:
> 
>   This wasn't caught by most people running the tests, even though
>   common shells like dash don't handle hex escapes, because their
>   systems don't trigger the NO_UTF16_BOM prereq. But systems with musl
>   libc do; when combined with dash, the test fails.

Make sense. I will take this note in the reroll.

-- 
Danh

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.