From: Danh Doan <congdanhqx@gmail.com>
Date: Fri, 01 Nov 2019 01:33:07 GMT
Subject: Re: [PATCH 1/3] t0028: eliminate non-standard usage of printf
Message-ID: <20191101013307.GD30350@danh.dev>
In-Reply-To: <20191031174118.GA2133@sigill.intra.peff.net>

On 2019-10-31 13:41:18 -0400, Jeff King wrote:
> So I think your patch is the right thing to do (hex escapes in shell
> printf are definitely not portable), but we might want to note something
> like:
> 
>   This wasn't caught by most people running the tests, even though
>   common shells like dash don't handle hex escapes, because their
>   systems don't trigger the NO_UTF16_BOM prereq. But systems with musl
>   libc do; when combined with dash, the test fails.

Make sense. I will take this note in the reroll.

-- 
Danh