git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] add trace2 regions to fetch & push

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Oct 7, 2019, 23:55 UTC
Message-ID
<20191007235532.9320-1-jonathantanmy@google.com>
In-Reply-To
<cover.1570487473.git.steadmon@google.com>
> Changes since V1:
> * Use the repository struct argument in transport_push(), rather than
>   the global the_repository.

Thanks, the patches now look good to me. I verified that the repository argument to the trace functions just cause a different repo ID to be printed, which is what we want (e.g. fn_region_enter_printf_va_fl() in tr2_tgt_event.c, which appears in the vtable defined at the bottom of the file).

Previous: Josh Steadmon
Message 11 of 11 in “add trace2 regions to fetch & push”
  1. 0/2 add trace2 regions to fetch & pushJosh Steadmon, Oct 2, 2019
  2. 1/2 fetch: add trace2 instrumentationJosh Steadmon, Oct 2, 2019
  3. 2/2 push: add trace2 instrumentationJosh Steadmon, Oct 2, 2019
  4. Jonathan TanOct 7, 2019
  5. Josh SteadmonOct 7, 2019
  6. Junio C HamanoOct 8, 2019
  7. Junio C HamanoOct 8, 2019
  8. 0/2 add trace2 regions to fetch & pushJosh Steadmon, Oct 7, 2019
  9. 1/2 fetch: add trace2 instrumentationJosh Steadmon, Oct 7, 2019
  10. 2/2 push: add trace2 instrumentationJosh Steadmon, Oct 7, 2019
  11. Jonathan TanOct 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.