git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] add trace2 regions to fetch & push

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Oct 7, 2019, 21:46 UTC
Message-ID
<20191007214644.236055-1-jonathantanmy@google.com>
In-Reply-To
<cover.1570059953.git.steadmon@google.com>
> We'd like to collect better statistics about where the time is spent in
> fetches and pushes so that we can hopefully identify some areas for
> future optimization. So let's add some trace2 regions around some of the
> fetch/push phases so we can break down their timing.
Thanks.

Patch 1 looks good to me - different regions at the same level (builtin/fetch.c, so it will be just for "git fetch") and one specific one just for negotiation, which has to be in fetch-pack.c because only that file operates at that level.

Patch 2 mostly looks good to me too - unlike fetch, a lot happens in transport.c, so it's reasonable to put most of the regions there. One comment: in transport_push(), should trace2_region_{enter,leave} take "r" instead of "the_repository"?

Previous: Josh SteadmonNext: Josh Steadmon
Message 4 of 11 in “add trace2 regions to fetch & push”
  1. 0/2 add trace2 regions to fetch & pushJosh Steadmon, Oct 2, 2019
  2. 1/2 fetch: add trace2 instrumentationJosh Steadmon, Oct 2, 2019
  3. 2/2 push: add trace2 instrumentationJosh Steadmon, Oct 2, 2019
  4. Jonathan TanOct 7, 2019
  5. Josh SteadmonOct 7, 2019
  6. Junio C HamanoOct 8, 2019
  7. Junio C HamanoOct 8, 2019
  8. 0/2 add trace2 regions to fetch & pushJosh Steadmon, Oct 7, 2019
  9. 1/2 fetch: add trace2 instrumentationJosh Steadmon, Oct 7, 2019
  10. 2/2 push: add trace2 instrumentationJosh Steadmon, Oct 7, 2019
  11. Jonathan TanOct 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.