git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 06/15] t4010: abstract away SHA-1-specific constants

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 5, 2019, 21:12 UTC
Message-ID
<20191005211209.18237-7-sandals@crustytoothpaste.net>
In-Reply-To
<20191005211209.18237-1-sandals@crustytoothpaste.net>

Adjust the test so that it computes variables for object IDs instead of using hard-coded hashes.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t4010-diff-pathspec.sh | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh
index 281f8fad0c..e5ca359edf 100755
--- a/t/t4010-diff-pathspec.sh
+++ b/t/t4010-diff-pathspec.sh
@@ -17,11 +17,15 @@ test_expect_success \
     'echo frotz >file0 &&
      mkdir path1 &&
      echo rezrov >path1/file1 &&
+     before0=$(git hash-object file0) &&
+     before1=$(git hash-object path1/file1) &&
      git update-index --add file0 path1/file1 &&
      tree=$(git write-tree) &&
      echo "$tree" &&
      echo nitfol >file0 &&
      echo yomin >path1/file1 &&
+     after0=$(git hash-object file0) &&
+     after1=$(git hash-object path1/file1) &&
      git update-index file0 path1/file1'
 
 cat >expected <<\EOF
@@ -31,32 +35,32 @@ test_expect_success \
     'git diff-index --cached $tree -- path >current &&
      compare_diff_raw current expected'
 
-cat >expected <<\EOF
-:100644 100644 766498d93a4b06057a8e49d23f4068f1170ff38f 0a41e115ab61be0328a19b29f18cdcb49338d516 M	path1/file1
+cat >expected <<EOF
+:100644 100644 $before1 $after1 M	path1/file1
 EOF
 test_expect_success \
     'limit to path1 should show path1/file1' \
     'git diff-index --cached $tree -- path1 >current &&
      compare_diff_raw current expected'
 
-cat >expected <<\EOF
-:100644 100644 766498d93a4b06057a8e49d23f4068f1170ff38f 0a41e115ab61be0328a19b29f18cdcb49338d516 M	path1/file1
+cat >expected <<EOF
+:100644 100644 $before1 $after1 M	path1/file1
 EOF
 test_expect_success \
     'limit to path1/ should show path1/file1' \
     'git diff-index --cached $tree -- path1/ >current &&
      compare_diff_raw current expected'
 
-cat >expected <<\EOF
-:100644 100644 766498d93a4b06057a8e49d23f4068f1170ff38f 0a41e115ab61be0328a19b29f18cdcb49338d516 M	path1/file1
+cat >expected <<EOF
+:100644 100644 $before1 $after1 M	path1/file1
 EOF
 test_expect_success \
     '"*file1" should show path1/file1' \
     'git diff-index --cached $tree -- "*file1" >current &&
      compare_diff_raw current expected'
 
-cat >expected <<\EOF
-:100644 100644 8e4020bb5a8d8c873b25de15933e75cc0fc275df dca6b92303befc93086aa025d90a5facd7eb2812 M	file0
+cat >expected <<EOF
+:100644 100644 $before0 $after0 M	file0
 EOF
 test_expect_success \
     'limit to file0 should show file0' \
Previous: Derrick StoleeNext: brian m. carlson
Message 16 of 24 in “SHA-256 test fixes, part 6”
  1. 00/15 SHA-256 test fixes, part 6brian m. carlson, Oct 5, 2019
  2. 01/15 t/oid-info: allow looking up hash algorithm namebrian m. carlson, Oct 5, 2019
  3. 04/15 t1305: avoid comparing extensionsbrian m. carlson, Oct 5, 2019
  4. 02/15 t/oid-info: add empty tree and empty blob valuesbrian m. carlson, Oct 5, 2019
  5. 05/15 t3429: remove SHA1 annotationbrian m. carlson, Oct 5, 2019
  6. 07/15 t4011: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  7. Derrick StoleeOct 8, 2019
  8. Bert WesargOct 8, 2019
  9. Derrick StoleeOct 8, 2019
  10. brian m. carlsonOct 8, 2019
  11. 03/15 rev-parse: add an --object-format optionbrian m. carlson, Oct 5, 2019
  12. Derrick StoleeOct 8, 2019
  13. brian m. carlsonOct 8, 2019
  14. 08/15 t4015: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  15. Derrick StoleeOct 8, 2019
  16. 06/15 t4010: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  17. 11/15 t4038: abstract away SHA-1 specific constantsbrian m. carlson, Oct 5, 2019
  18. 12/15 t4039: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  19. 09/15 t4027: make hash-size independentbrian m. carlson, Oct 5, 2019
  20. 13/15 t4044: update test to work with SHA-256brian m. carlson, Oct 5, 2019
  21. 15/15 t4048: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  22. 14/15 t4045: make hash-size independentbrian m. carlson, Oct 5, 2019
  23. 10/15 t4034: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  24. Derrick StoleeOct 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.