git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/15] SHA-256 test fixes, part 6

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 5, 2019, 21:11 UTC
Message-ID
<20191005211209.18237-1-sandals@crustytoothpaste.net>

This series consists mostly of additional test fixes for SHA-256, plus some test framework improvements and a new option to rev-parse.

Up until now, most of the test changes have been directly related to fixing hash values or sizes in some way. In other words, previous test fixes would be required even for a Git binary that supported only SHA-256 and not SHA-1.

In this series, we also introduce some test changes that deal with the extension that will allow the same binary to handle both. The changes themselves are relatively uninteresting, but changes like these will be making appearances in future test fix series as well. They may appear bizarre and out of place at times, but rest assured that they will be useful in the future.

The other notable thing in this series is the introduction of a new rev-parse option, --object-format. We know, according to the transition plan, that we'll need to support users working with input and output in different hash algorithms. Since we're starting to see this kind of code appear in the codebase, it makes sense to introduce a helper that lets scripters determine the appropriate value, and we should introduce this code sooner, rather than later, so people can start using it.

We had had some discussions about the name of options to be used for hash algorithms but I don't recall us coming to a definitive conclusion. Opinions about the name[0] are of course welcome. I'm not particularly attached to any name, so whatever the consensus is works for me.

[0] Possibilities include --object-format, --show-object-format, --hash, --show-hash, --hash-algorithm, --show-hash-algorithm, and more.

brian m. carlson (15):
  t/oid-info: allow looking up hash algorithm name
  t/oid-info: add empty tree and empty blob values
  rev-parse: add an --object-format option
  t1305: avoid comparing extensions
  t3429: remove SHA1 annotation
  t4010: abstract away SHA-1-specific constants
  t4011: abstract away SHA-1-specific constants
  t4015: abstract away SHA-1-specific constants
  t4027: make hash-size independent
  t4034: abstract away SHA-1-specific constants
  t4038: abstract away SHA-1 specific constants
  t4039: abstract away SHA-1-specific constants
  t4044: update test to work with SHA-256
  t4045: make hash-size independent
  t4048: abstract away SHA-1-specific constants
 Documentation/git-rev-parse.txt     |  7 +++
 builtin/rev-parse.c                 | 11 ++++
 t/oid-info/hash-info                |  9 +++
 t/t1305-config-include.sh           |  2 +-
 t/t1500-rev-parse.sh                | 15 +++++
 t/t3429-rebase-edit-todo.sh         |  2 +-
 t/t4010-diff-pathspec.sh            | 20 ++++---
 t/t4011-diff-symlink.sh             | 31 ++++++----
 t/t4015-diff-whitespace.sh          | 89 ++++++++++++++++-----------
 t/t4027-diff-submodule.sh           | 16 ++---
 t/t4034-diff-words.sh               | 93 +++++++++++++++++------------
 t/t4038-diff-combined.sh            | 19 ++++--
 t/t4039-diff-assume-unchanged.sh    |  3 +-
 t/t4044-diff-index-unique-abbrev.sh | 46 +++++++++-----
 t/t4045-diff-relative.sh            |  2 +-
 t/t4048-diff-combined-binary.sh     | 58 ++++++++++--------
 16 files changed, 268 insertions(+), 155 deletions(-)
Next: brian m. carlson
Message 1 of 24 in “SHA-256 test fixes, part 6”
  1. 00/15 SHA-256 test fixes, part 6brian m. carlson, Oct 5, 2019
  2. 01/15 t/oid-info: allow looking up hash algorithm namebrian m. carlson, Oct 5, 2019
  3. 04/15 t1305: avoid comparing extensionsbrian m. carlson, Oct 5, 2019
  4. 02/15 t/oid-info: add empty tree and empty blob valuesbrian m. carlson, Oct 5, 2019
  5. 05/15 t3429: remove SHA1 annotationbrian m. carlson, Oct 5, 2019
  6. 07/15 t4011: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  7. Derrick StoleeOct 8, 2019
  8. Bert WesargOct 8, 2019
  9. Derrick StoleeOct 8, 2019
  10. brian m. carlsonOct 8, 2019
  11. 03/15 rev-parse: add an --object-format optionbrian m. carlson, Oct 5, 2019
  12. Derrick StoleeOct 8, 2019
  13. brian m. carlsonOct 8, 2019
  14. 08/15 t4015: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  15. Derrick StoleeOct 8, 2019
  16. 06/15 t4010: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  17. 11/15 t4038: abstract away SHA-1 specific constantsbrian m. carlson, Oct 5, 2019
  18. 12/15 t4039: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  19. 09/15 t4027: make hash-size independentbrian m. carlson, Oct 5, 2019
  20. 13/15 t4044: update test to work with SHA-256brian m. carlson, Oct 5, 2019
  21. 15/15 t4048: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  22. 14/15 t4045: make hash-size independentbrian m. carlson, Oct 5, 2019
  23. 10/15 t4034: abstract away SHA-1-specific constantsbrian m. carlson, Oct 5, 2019
  24. Derrick StoleeOct 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.