Re: [PATCH v2] cache-tree: do not lazy-fetch merge tree

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Sep 10, 2019, 12:49 UTC
Message-ID: <20190910124920.GI32087@szeder.dev>
In-Reply-To: <20190909190130.146613-1-jonathantanmy@google.com>

On Mon, Sep 09, 2019 at 12:01:30PM -0700, Jonathan Tan wrote:

Show 22 quoted lines

> diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh
> index 6415063980..3e434b6a81 100755
> --- a/t/t0410-partial-clone.sh
> +++ b/t/t0410-partial-clone.sh
> @@ -492,6 +492,20 @@ test_expect_success 'gc stops traversal when a missing but promised object is re
>  	! grep "$TREE_HASH" out
>  '
>  
> +test_expect_success 'do not fetch when checking existence of tree we construct ourselves' '
> +	rm -rf repo &&
> +	test_create_repo repo &&
> +	test_commit -C repo base &&
> +	test_commit -C repo side1 &&
> +	git -C repo checkout base &&
> +	test_commit -C repo side2 &&
> +
> +	git -C repo config core.repositoryformatversion 1 &&
> +	git -C repo config extensions.partialclone "arbitrary string" &&
> +
> +	git -C repo cherry-pick side1
> +'
> +

Sidenote, just curious: did you originally intend to add this test before the test script sources 'lib-httpd.sh', or you were about to append it at the end as usual, but then noticed the warning comment telling you not to do so?

>  . "$TEST_DIRECTORY"/lib-httpd.sh
>  start_httpd