Re: [PATCH] Documentation: fix build with Asciidoctor 2
- From
Jeff King <peff@peff.net>
- Date
- Sep 8, 2019, 21:32 UTC
- Message-ID
- <20190908213233.GC8514@sigill.intra.peff.net>
- In-Reply-To
- <20190908141308.GA7255@szeder.dev>
On Sun, Sep 08, 2019 at 04:13:08PM +0200, SZEDER Gábor wrote:
Show 6 quoted lines
> OTOH, these "stripped namespace" messages come from 'xmlto', are not > warnings but have that "Note:" prefix, and, trusting that you did > check the results thoroughly, are apparently not a sign of any > rendering issues. So I think it's safe to ignore them and this patch > should strip them from 'make doc's output in > 'ci/test-documentation.sh'.
Yeah, I'd agree (though I do think there are some other issues with this approach, at least in my tests).
If we do go this route, it might even be nice to use a small xmlto wrapper that filters the stderr for us. Then the ci code doesn't have to know about this distinction, and it prevents users from seeing the ugly messages.
-Peff