Re: [PATCH] asciidoctor-extensions: provide `<refmiscinfo/>`
- From
Todd Zullinger <tmz@pobox.com>
- Date
- Mar 25, 2019, 19:00 UTC
- Message-ID
- <20190325190041.GM4047@pobox.com>
- In-Reply-To
- <20190325150633.GC19929@sigill.intra.peff.net>
Hi,
Jeff King wrote:
Show 7 quoted lines
> On Sun, Mar 24, 2019 at 12:21:31PM -0400, Todd Zullinger wrote: >> I'm curious why manpage builds work for you and not for me. > > I think it's because I'm an idiot. I must have only been using 2.0.0 > when I was looking at the XML output manually (for the refmiscinfo > lines), and never actually rendered it to roff. I get the same problem > when I try a full build.
Ahh. I was hoping you'd tell me that I was a fool. :)
Show 14 quoted lines
>> On my fedora 29 test system, ASCIIDOC_DOCBOOK=docbook5 leads >> to a validation failure from xmlto, since docbook5 doesn't >> use a DTD¹. I added XMLTO_EXTRA = --skip-validation to the >> USE_ASCIIDOCTOR block, which can build many of the man >> pages, but fails when it gets to git-blame due to use of >> literal < > characters in the xml: >> >> git-blame.xml:423: parser error : StartTag: invalid element name >> <literallayout class="monospaced"><40-byte hex sha1> <sourceline> <resultline> < >> ^ > > That seems like a bug in asciidoctor, which ought to be quoting the "<". > We certainly can't quote it ourselves (we don't even know that our > backend output is going to a format that needs angle brackets quoted).
Yep, it seems so. I filed this upstream:
https://github.com/asciidoctor/asciidoctor/issues/3205
I updated to asciidoctor-2.0.1 this morning to test, in case it was one of the issues fixed since the 2.0.0 release. Alas, we're the first to hit it and report it.
-- Todd