git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t0021: make sure clean filter runs

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Aug 23, 2019, 08:34 UTC
Message-ID
<20190823083447.GH20404@szeder.dev>
In-Reply-To
<20190822192240.GA4077@cat>
On Thu, Aug 22, 2019 at 08:22:40PM +0100, Thomas Gummerer wrote:
> v2 adds the comment as suggested by Szeder.
> +		# Make sure that the file appears dirty, so checkout below has to
> +		# run the configured filter.

Yeah, but that comment only really applied when setting both timestamps. With a simple 'touch' it's more like

  # Make sure that the file appears dirty or is at least racily clean,
  # so ...

So the next reader will know that right away, that the author didn't overlook racyness issue.

Show 7 quoted lines
> +		touch test.r &&
>  		filter_git checkout --quiet --no-progress empty-branch &&
>  		cat >expected.log <<-EOF &&
>  			START
> -- 
> 2.23.0.rc2.194.ge5444969c9
>
Previous: Junio C Hamano
Message 14 of 14 in “t0021: make sure clean filter runs”
  1. t0021: make sure clean filter runsThomas Gummerer, Aug 20, 2019
  2. Junio C HamanoAug 20, 2019
  3. Thomas GummererAug 21, 2019
  4. Junio C HamanoAug 21, 2019
  5. Johannes SixtAug 20, 2019
  6. Thomas GummererAug 21, 2019
  7. Johannes SixtAug 21, 2019
  8. SZEDER GáborAug 21, 2019
  9. Thomas GummererAug 22, 2019
  10. Junio C HamanoAug 22, 2019
  11. Johannes SixtAug 22, 2019
  12. t0021: make sure clean filter runsThomas Gummerer, Aug 22, 2019
  13. Junio C HamanoAug 22, 2019
  14. SZEDER GáborAug 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.