Re: [PATCH] t0021: make sure clean filter runs

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Aug 21, 2019, 14:56 UTC
Message-ID: <20190821145616.GB2679@cat>
In-Reply-To: <aea64308-fcba-77a1-1196-182b35ad405c@kdbg.org>

On 08/20, Johannes Sixt wrote:

Show 16 quoted lines

> Am 20.08.19 um 08:56 schrieb Thomas Gummerer:
> > Fix the test by updating the mtime of test.r, ...
> 
> > diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
> > index e10f5f787f..66f75005d5 100755
> > --- a/t/t0021-conversion.sh
> > +++ b/t/t0021-conversion.sh
> > @@ -390,6 +390,7 @@ test_expect_success PERL 'required process filter should filter data' '
> >  		EOF
> >  		test_cmp_exclude_clean expected.log debug.log &&
> >  
> > +		touch test.r &&
> 
> 		test-tool chmtime +10 test.r
> 
> would be more reliable.

Hmm, is touch unreliable on some platforms? I didn't think of 'test-tool chmtime', but I'm also not sure it's better than touch in this case.

To me te 'touch' signifies that the timestamp must be updated after the previous checkout, so git thinks it could possibly have been changed, which I think is clearer in this case than setting the mtime to a future time.

But I'm happy to change it if there's something I'm missing why 'test-tool chmtime' is better in this case.

Show 6 quoted lines

> >  		filter_git checkout --quiet --no-progress empty-branch &&
> >  		cat >expected.log <<-EOF &&
> >  			START
> > 
> 
> -- Hannes