git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Simplify-by-decoration with decorate-refs-exclude

From
Jeff King <peff@peff.net>
Date
Aug 2, 2019, 23:21 UTC
Message-ID
<20190802232129.GA811@sigill.intra.peff.net>
In-Reply-To
<xmqqh86zjmcg.fsf@gitster-ct.c.googlers.com>
On Fri, Aug 02, 2019 at 02:20:31PM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> > This would require that higher level to parse the user format to check
> > if %d or %D is present before formatting the first item.  Hmm.
> 
> Yes.  Don't we pre-scan what kind of formatting primitives are used
> in the end-user supplied string already to optimize loading of notes
> and source information?
I think userformat_find_requirements() is what you're looking for.

I do think it might be tricky to find all of the callers who need to use it, though. Some of them are not necessarily users of the traversal machinery, but just have a one-off pretty_print_context.

-Peff
Previous: Junio C HamanoNext: René Scharfe
Message 6 of 11 in “Simplify-by-decoration with decorate-refs-exclude”
  1. Étienne SERVAISAug 2, 2019
  2. René ScharfeAug 2, 2019
  3. Junio C HamanoAug 2, 2019
  4. René ScharfeAug 2, 2019
  5. Junio C HamanoAug 2, 2019
  6. Jeff KingAug 2, 2019
  7. René ScharfeAug 3, 2019
  8. Junio C HamanoAug 3, 2019
  9. 1/2 log: test --decorate-refs-exclude with --simplify-by-decorationRené Scharfe, Sep 8, 2019
  10. Junio C HamanoSep 9, 2019
  11. 2/2 log-tree: call load_ref_decorations() in get_name_decoration()René Scharfe, Sep 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.