git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] t7700: clean up .keep file in bitmap-writing test

From
Jeff King <peff@peff.net>
Date
Jul 31, 2019, 05:37 UTC
Message-ID
<20190731053735.GA16941@sigill.intra.peff.net>
In-Reply-To
<20190731053703.GA16709@sigill.intra.peff.net>

After our test snippet finishes, the .keep file is left in place, making it hard to do further tests of the auto-bitmap-writing code (since it suppresses the feature completely). Let's clean it up.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/t7700-repack.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh
index 0e9af832c9..8d9a358df8 100755
--- a/t/t7700-repack.sh
+++ b/t/t7700-repack.sh
@@ -243,6 +243,7 @@ test_expect_success 'no bitmaps created if .keep files present' '
 	pack=$(ls bare.git/objects/pack/*.pack) &&
 	test_path_is_file "$pack" &&
 	keep=${pack%.pack}.keep &&
+	test_when_finished "rm -f \"\$keep\"" &&
 	>"$keep" &&
 	git -C bare.git repack -ad &&
 	find bare.git/objects/pack/ -type f -name "*.bitmap" >actual &&
-- 
2.23.0.rc0.426.gbdee707ba7
Previous: Jeff KingNext: Jeff King
Message 6 of 11 in “Warnings in gc.log can prevent gc --auto from running”
  1. Gregory SzorcJul 26, 2019
  2. Jeff KingJul 29, 2019
  3. Ævar Arnfjörð BjarmasonJul 29, 2019
  4. Jeff KingJul 31, 2019
  5. 0/3 handling warnings due to auto-enabled bitmapsJeff King, Jul 31, 2019
  6. 1/3 t7700: clean up .keep file in bitmap-writing testJeff King, Jul 31, 2019
  7. 2/3 repack: silence warnings when auto-enabled bitmaps cannot be builtJeff King, Jul 31, 2019
  8. Junio C HamanoJul 31, 2019
  9. Jeff KingJul 31, 2019
  10. 3/3 repack: simplify handling of auto-bitmaps and .keep filesJeff King, Jul 31, 2019
  11. Junio C HamanoJul 31, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.