git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] handling warnings due to auto-enabled bitmaps

From
Jeff King <peff@peff.net>
Date
Jul 31, 2019, 05:37 UTC
Message-ID
<20190731053703.GA16709@sigill.intra.peff.net>
In-Reply-To
<20190731042807.GA26237@sigill.intra.peff.net>
On Wed, Jul 31, 2019 at 12:28:07AM -0400, Jeff King wrote:
Show 20 quoted lines
> On Mon, Jul 29, 2019 at 02:50:56PM +0200, Ævar Arnfjörð Bjarmason wrote:
> 
> > > Instead, it may make sense to turn the --write-bitmap-index option of
> > > pack-objects into a tri-state: true/false/auto. Then pack-objects would
> > > know that we are in best-effort mode, and would avoid warning in that
> > > case. That would also let git-repack express its intentions better to
> > > git-pack-objects, so we could replace 7328482253, and keep more of the
> > > logic in pack-objects, which is ultimately what has to make the decision
> > > about whether it can generate bitmaps.
> > 
> > Sounds like pentastate to me :) (penta = 5, had to look it up). I.e. in
> > most cases of "auto" we pick a true/false at the outset, whereas this is
> > true/true-but-dont-care-much/false/false-but-dont-care-much with "auto"
> > picking the "-but-dont-care-much" versions of a "soft" true/false.
> 
> I don't think we care about false-but-dont-care-much. Pack-objects just
> needs to know whether the bitmaps are the user's expressed intention, or
> just something that it should do if it's convenient.
> 
> I'll see if I can work up a patch to demonstrate.

This actually turned out pretty well, I think. I wish I had thought of it when were initially looking at the .keep stuff. :) It was not too hard to clean that up in the third patch, though.

  [1/3]: t7700: clean up .keep file in bitmap-writing test
  [2/3]: repack: silence warnings when auto-enabled bitmaps cannot be built
  [3/3]: repack: simplify handling of auto-bitmaps and .keep files
 builtin/pack-objects.c | 21 ++++++++++++++++-----
 builtin/repack.c       | 24 +++++++-----------------
 t/t7700-repack.sh      | 15 ++++++++++++++-
 3 files changed, 37 insertions(+), 23 deletions(-)
Previous: Jeff KingNext: Jeff King
Message 5 of 11 in “Warnings in gc.log can prevent gc --auto from running”
  1. Gregory SzorcJul 26, 2019
  2. Jeff KingJul 29, 2019
  3. Ævar Arnfjörð BjarmasonJul 29, 2019
  4. Jeff KingJul 31, 2019
  5. 0/3 handling warnings due to auto-enabled bitmapsJeff King, Jul 31, 2019
  6. 1/3 t7700: clean up .keep file in bitmap-writing testJeff King, Jul 31, 2019
  7. 2/3 repack: silence warnings when auto-enabled bitmaps cannot be builtJeff King, Jul 31, 2019
  8. Junio C HamanoJul 31, 2019
  9. Jeff KingJul 31, 2019
  10. 3/3 repack: simplify handling of auto-bitmaps and .keep filesJeff King, Jul 31, 2019
  11. Junio C HamanoJul 31, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.