git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 04/15] promisor-remote: implement promisor_remote_get_direct()

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 25, 2019, 13:40 UTC
Message-ID
<20190625134039.21707-5-chriscool@tuxfamily.org>
In-Reply-To
<20190625134039.21707-1-chriscool@tuxfamily.org>
From: Christian Couder <christian.couder@gmail.com>

This is implemented for now by calling fetch_objects(). It fetches from all the promisor remotes.

Helped-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Helped-by: Derrick Stolee <stolee@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 promisor-remote.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++
 promisor-remote.h |  5 ++++
 2 files changed, 72 insertions(+)
diff --git a/promisor-remote.c b/promisor-remote.c
index c249b80e02..b79a84ce3a 100644
--- a/promisor-remote.c
+++ b/promisor-remote.c
@@ -1,6 +1,8 @@
 #include "cache.h"
+#include "object-store.h"
 #include "promisor-remote.h"
 #include "config.h"
+#include "fetch-object.h"
 
 static struct promisor_remote *promisors;
 static struct promisor_remote **promisors_tail = &promisors;
@@ -90,3 +92,68 @@ int has_promisor_remote(void)
 {
 	return !!promisor_remote_find(NULL);
 }
+
+static int remove_fetched_oids(struct repository *repo,
+			       struct object_id **oids,
+			       int oid_nr, int to_free)
+{
+	int i, remaining_nr = 0;
+	int *remaining = xcalloc(oid_nr, sizeof(*remaining));
+	struct object_id *old_oids = *oids;
+	struct object_id *new_oids;
+
+	for (i = 0; i < oid_nr; i++)
+		if (oid_object_info_extended(repo, &old_oids[i], NULL,
+					     OBJECT_INFO_SKIP_FETCH_OBJECT)) {
+			remaining[i] = 1;
+			remaining_nr++;
+		}
+
+	if (remaining_nr) {
+		int j = 0;
+		new_oids = xcalloc(remaining_nr, sizeof(*new_oids));
+		for (i = 0; i < oid_nr; i++)
+			if (remaining[i])
+				oidcpy(&new_oids[j++], &old_oids[i]);
+		*oids = new_oids;
+		if (to_free)
+			free(old_oids);
+	}
+
+	free(remaining);
+
+	return remaining_nr;
+}
+
+int promisor_remote_get_direct(struct repository *repo,
+			       const struct object_id *oids,
+			       int oid_nr)
+{
+	struct promisor_remote *r;
+	struct object_id *remaining_oids = (struct object_id *)oids;
+	int remaining_nr = oid_nr;
+	int to_free = 0;
+	int res = -1;
+
+	promisor_remote_init();
+
+	for (r = promisors; r; r = r->next) {
+		if (fetch_objects(r->name, remaining_oids, remaining_nr) < 0) {
+			if (remaining_nr == 1)
+				continue;
+			remaining_nr = remove_fetched_oids(repo, &remaining_oids,
+							 remaining_nr, to_free);
+			if (remaining_nr) {
+				to_free = 1;
+				continue;
+			}
+		}
+		res = 0;
+		break;
+	}
+
+	if (to_free)
+		free(remaining_oids);
+
+	return res;
+}
diff --git a/promisor-remote.h b/promisor-remote.h
index 01dcdf4dc7..ed4ecead36 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -1,6 +1,8 @@
 #ifndef PROMISOR_REMOTE_H
 #define PROMISOR_REMOTE_H
 
+struct object_id;
+
 /*
  * Promisor remote linked list
  * Its information come from remote.XXX config entries.
@@ -12,5 +14,8 @@ struct promisor_remote {
 
 extern struct promisor_remote *promisor_remote_find(const char *remote_name);
 extern int has_promisor_remote(void);
+extern int promisor_remote_get_direct(struct repository *repo,
+				      const struct object_id *oids,
+				      int oid_nr);
 
 #endif /* PROMISOR_REMOTE_H */
-- 
2.22.0.229.ga13d9ffdf7.dirty
Previous: Christian CouderNext: Christian Couder
Message 7 of 16 in “Many promisor remotes”
  1. 00/15 Many promisor remotesChristian Couder, Jun 25, 2019
  2. 01/15 t0410: remove pipes after git commandsChristian Couder, Jun 25, 2019
  3. 02/15 fetch-object: make functions return an error codeChristian Couder, Jun 25, 2019
  4. 03/15 Add initial support for many promisor remotesChristian Couder, Jun 25, 2019
  5. 05/15 promisor-remote: add promisor_remote_reinit()Christian Couder, Jun 25, 2019
  6. 06/15 promisor-remote: use repository_format_partial_cloneChristian Couder, Jun 25, 2019
  7. 04/15 promisor-remote: implement promisor_remote_get_direct()Christian Couder, Jun 25, 2019
  8. 09/15 builtin/fetch: remove unique promisor remote limitationChristian Couder, Jun 25, 2019
  9. 08/15 promisor-remote: parse remote.*.partialclonefilterChristian Couder, Jun 25, 2019
  10. 10/15 t0410: test fetching from many promisor remotesChristian Couder, Jun 25, 2019
  11. 11/15 partial-clone: add multiple remotes in the docChristian Couder, Jun 25, 2019
  12. 14/15 Move repository_format_partial_clone to promisor-remote.cChristian Couder, Jun 25, 2019
  13. 15/15 Move core_partial_clone_filter_default to promisor-remote.cChristian Couder, Jun 25, 2019
  14. 12/15 remote: add promisor and partial clone config to the docChristian Couder, Jun 25, 2019
  15. 13/15 Remove fetch-object.{c,h} in favor of promisor-remote.{c,h}Christian Couder, Jun 25, 2019
  16. 07/15 Use promisor_remote_get_direct() and has_promisor_remote()Christian Couder, Jun 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.