git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 03/15] Add initial support for many promisor remotes

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 25, 2019, 13:40 UTC
Message-ID
<20190625134039.21707-4-chriscool@tuxfamily.org>
In-Reply-To
<20190625134039.21707-1-chriscool@tuxfamily.org>
From: Christian Couder <christian.couder@gmail.com>

The promisor-remote.{c,h} files will contain functions to manage many promisor remotes.

We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them.

Helped-by: Jeff King <peff@peff.net>
Helped-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 Makefile          |  1 +
 promisor-remote.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++
 promisor-remote.h | 16 +++++++++
 3 files changed, 109 insertions(+)
 create mode 100644 promisor-remote.c
 create mode 100644 promisor-remote.h
diff --git a/Makefile b/Makefile
index f58bf14c7b..049bc8cfd4 100644
--- a/Makefile
+++ b/Makefile
@@ -944,6 +944,7 @@ LIB_OBJS += preload-index.o
 LIB_OBJS += pretty.o
 LIB_OBJS += prio-queue.o
 LIB_OBJS += progress.o
+LIB_OBJS += promisor-remote.o
 LIB_OBJS += prompt.o
 LIB_OBJS += protocol.o
 LIB_OBJS += quote.o
diff --git a/promisor-remote.c b/promisor-remote.c
new file mode 100644
index 0000000000..c249b80e02
--- /dev/null
+++ b/promisor-remote.c
@@ -0,0 +1,92 @@
+#include "cache.h"
+#include "promisor-remote.h"
+#include "config.h"
+
+static struct promisor_remote *promisors;
+static struct promisor_remote **promisors_tail = &promisors;
+
+static struct promisor_remote *promisor_remote_new(const char *remote_name)
+{
+	struct promisor_remote *r;
+
+	if (*remote_name == '/') {
+		warning(_("promisor remote name cannot begin with '/': %s"),
+			remote_name);
+		return NULL;
+	}
+
+	FLEX_ALLOC_STR(r, name, remote_name);
+
+	*promisors_tail = r;
+	promisors_tail = &r->next;
+
+	return r;
+}
+
+static struct promisor_remote *promisor_remote_lookup(const char *remote_name,
+						      struct promisor_remote **previous)
+{
+	struct promisor_remote *r, *p;
+
+	for (p = NULL, r = promisors; r; p = r, r = r->next)
+		if (!strcmp(r->name, remote_name)) {
+			if (previous)
+				*previous = p;
+			return r;
+		}
+
+	return NULL;
+}
+
+static int promisor_remote_config(const char *var, const char *value, void *data)
+{
+	const char *name;
+	int namelen;
+	const char *subkey;
+
+	if (parse_config_key(var, "remote", &name, &namelen, &subkey) < 0)
+		return 0;
+
+	if (!strcmp(subkey, "promisor")) {
+		char *remote_name;
+
+		if (!git_config_bool(var, value))
+			return 0;
+
+		remote_name = xmemdupz(name, namelen);
+
+		if (!promisor_remote_lookup(remote_name, NULL))
+			promisor_remote_new(remote_name);
+
+		free(remote_name);
+		return 0;
+	}
+
+	return 0;
+}
+
+static void promisor_remote_init(void)
+{
+	static int initialized;
+
+	if (initialized)
+		return;
+	initialized = 1;
+
+	git_config(promisor_remote_config, NULL);
+}
+
+struct promisor_remote *promisor_remote_find(const char *remote_name)
+{
+	promisor_remote_init();
+
+	if (!remote_name)
+		return promisors;
+
+	return promisor_remote_lookup(remote_name, NULL);
+}
+
+int has_promisor_remote(void)
+{
+	return !!promisor_remote_find(NULL);
+}
diff --git a/promisor-remote.h b/promisor-remote.h
new file mode 100644
index 0000000000..01dcdf4dc7
--- /dev/null
+++ b/promisor-remote.h
@@ -0,0 +1,16 @@
+#ifndef PROMISOR_REMOTE_H
+#define PROMISOR_REMOTE_H
+
+/*
+ * Promisor remote linked list
+ * Its information come from remote.XXX config entries.
+ */
+struct promisor_remote {
+	struct promisor_remote *next;
+	const char name[FLEX_ARRAY];
+};
+
+extern struct promisor_remote *promisor_remote_find(const char *remote_name);
+extern int has_promisor_remote(void);
+
+#endif /* PROMISOR_REMOTE_H */
-- 
2.22.0.229.ga13d9ffdf7.dirty
Previous: Christian CouderNext: Christian Couder
Message 4 of 16 in “Many promisor remotes”
  1. 00/15 Many promisor remotesChristian Couder, Jun 25, 2019
  2. 01/15 t0410: remove pipes after git commandsChristian Couder, Jun 25, 2019
  3. 02/15 fetch-object: make functions return an error codeChristian Couder, Jun 25, 2019
  4. 03/15 Add initial support for many promisor remotesChristian Couder, Jun 25, 2019
  5. 05/15 promisor-remote: add promisor_remote_reinit()Christian Couder, Jun 25, 2019
  6. 06/15 promisor-remote: use repository_format_partial_cloneChristian Couder, Jun 25, 2019
  7. 04/15 promisor-remote: implement promisor_remote_get_direct()Christian Couder, Jun 25, 2019
  8. 09/15 builtin/fetch: remove unique promisor remote limitationChristian Couder, Jun 25, 2019
  9. 08/15 promisor-remote: parse remote.*.partialclonefilterChristian Couder, Jun 25, 2019
  10. 10/15 t0410: test fetching from many promisor remotesChristian Couder, Jun 25, 2019
  11. 11/15 partial-clone: add multiple remotes in the docChristian Couder, Jun 25, 2019
  12. 14/15 Move repository_format_partial_clone to promisor-remote.cChristian Couder, Jun 25, 2019
  13. 15/15 Move core_partial_clone_filter_default to promisor-remote.cChristian Couder, Jun 25, 2019
  14. 12/15 remote: add promisor and partial clone config to the docChristian Couder, Jun 25, 2019
  15. 13/15 Remove fetch-object.{c,h} in favor of promisor-remote.{c,h}Christian Couder, Jun 25, 2019
  16. 07/15 Use promisor_remote_get_direct() and has_promisor_remote()Christian Couder, Jun 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.