Re: [PATCH v1 2/5] list-objects-filter-options: error is localizeable
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- May 24, 2019, 00:55 UTC
- Message-ID
- <20190524005512.GC46998@google.com>
- In-Reply-To
- <6f4da02d494323e3ca946b4b20bf78d9dee419e4.1558484115.git.matvore@google.com>
On Tue, May 21, 2019 at 05:21:51PM -0700, Matthew DeVore wrote:
> The "invalid filter-spec" message is user-facing and not a BUG, so make > it localizeable.
What does it look like? Is it human-readable in its current form? I ask because (without having looked ahead) I think you're going to move it from a BUG to a user-facing error in a later patchset (which I don't think the commit message reflects well). If I'm wrong, and today it's a possibly user-facing string, then I think this patch could stand on its own outside of this patchset, which would probably save you some effort keeping a simple change in limbo for a long time. But if I'm right, I think the commit message could use some work.
- Emily
Show 36 quoted lines
>
> Signed-off-by: Matthew DeVore <matvore@google.com>
> ---
> list-objects-filter-options.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
> index c0036f7378..e46ea467bc 100644
> --- a/list-objects-filter-options.c
> +++ b/list-objects-filter-options.c
> @@ -81,21 +81,21 @@ static int gently_parse_list_objects_filter(
> filter_options->choice = LOFC_SPARSE_PATH;
> filter_options->sparse_path_value = strdup(v0);
> return 0;
> }
> /*
> * Please update _git_fetch() in git-completion.bash when you
> * add new filters
> */
>
> if (errbuf)
> - strbuf_addf(errbuf, "invalid filter-spec '%s'", arg);
> + strbuf_addf(errbuf, _("invalid filter-spec '%s'"), arg);
>
> memset(filter_options, 0, sizeof(*filter_options));
> return 1;
> }
>
> int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
> const char *arg)
> {
> struct strbuf buf = STRBUF_INIT;
> if (gently_parse_list_objects_filter(filter_options, arg, &buf))
> --
> 2.21.0
>